[webkit-reviews] review granted: [Bug 120170] MediaPlayerPrivateAVFoundationObjC is painting video frames under the video layer : [Attachment 209917] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 28 13:17:24 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 120170: MediaPlayerPrivateAVFoundationObjC is painting video frames under
the video layer
https://bugs.webkit.org/show_bug.cgi?id=120170

Attachment 209917: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=209917&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209917&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:804
> +    
>  #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
>      paintWithVideoOutput(context, rect);
>  #else
>      paintWithImageGenerator(context, rect);
>  #endif
> -
> +    
>      END_BLOCK_OBJC_EXCEPTIONS;
>      setDelayCallbacks(false);
> -
> +    

Some non-empty lines here.


More information about the webkit-reviews mailing list