[webkit-reviews] review granted: [Bug 120432] REGRESSION(r154586): Past names map should only be used when named item is empty : [Attachment 209913] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 28 11:57:59 PDT 2013


Anders Carlsson <andersca at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 120432: REGRESSION(r154586): Past names map should only be used when named
item is empty
https://bugs.webkit.org/show_bug.cgi?id=120432

Attachment 209913: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=209913&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209913&action=review


> Source/WebCore/html/HTMLFormElement.cpp:684
> +    else if (elementFromPast && !namedItems.size())

Please use namedItems.isEmpty() instead.


More information about the webkit-reviews mailing list