[webkit-reviews] review denied: [Bug 120401] [GTK][WTR] Several editing/selection tests are flaky as ClickCounter is not reset between test runs : [Attachment 209863] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Simon Pena
<simon.pena at samsung.com>'s request for review:
Bug 120401: [GTK][WTR] Several editing/selection tests are flaky as
ClickCounter is not reset between test runs
https://bugs.webkit.org/show_bug.cgi?id=120401

Attachment 209863: Patch
https://bugs.webkit.org/attachment.cgi?id=209863&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209863&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1472
> +	   // Reset the click counter
> +	   webkitWebViewBaseResetClickCounter(WEBKIT_WEB_VIEW_BASE(webView));

This is probably not the right time to do this. Just because a new load started
doesn't mean the old page isn't active. Maybe a better time would be after the
document changes. It might be hard to track this in the UI process, so perhaps
it's better to wait for the first repaint that includes the new page. This
should probably also be in WebKitWebViewBase.