[webkit-reviews] review granted: [Bug 120326] CodeBlock compilation and installation should be simplified and rationalized : [Attachment 209846] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 120326: CodeBlock compilation and installation should be simplified and
rationalized
https://bugs.webkit.org/show_bug.cgi?id=120326

Attachment 209846: the patch
https://bugs.webkit.org/attachment.cgi?id=209846&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209846&action=review


r=me if you switch to having create methods for the new refcounted classes

> Source/JavaScriptCore/bytecode/DeferredCompilationCallback.h:38
> +public:
> +    DeferredCompilationCallback();

Can we give this a protected constructor and a public create method?

> Source/JavaScriptCore/jit/JITToDFGDeferredCompilationCallback.h:37
> +public:
> +    JITToDFGDeferredCompilationCallback();

can we make the constructor private, and give this a PassRefPtr returning
create() method?