[webkit-reviews] review denied: [Bug 120002] [CSS Masking] Add -webkit-mask-source-type shorthand property : [Attachment 209066] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Andrei Parvu <parvu at adobe.com>'s
request for review:
Bug 120002: [CSS Masking] Add -webkit-mask-source-type shorthand property
https://bugs.webkit.org/show_bug.cgi?id=120002

Attachment 209066: Patch
https://bugs.webkit.org/attachment.cgi?id=209066&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209066&action=review


Looks good to me. Just some snippets.

> Source/WebCore/css/CSSParser.cpp:2847
> +	   const CSSPropertyID properties[] = { CSSPropertyWebkitMaskImage,
CSSPropertyWebkitMaskRepeat, CSSPropertyWebkitMaskSourceType,

Put this right after MaskImage to match the spec please.

> Source/WebCore/css/StylePropertyShorthand.cpp:441
> +	   CSSPropertyWebkitMaskSourceType

Put this right after MaskImage to match the spec please.

> Source/WebCore/css/StylePropertyShorthand.cpp:888
> +	   map.set(CSSPropertyWebkitMaskSourceType, mask);

Ditto.