[webkit-reviews] review denied: [Bug 120300] AX:Null pointer may be dereferenced. : [Attachment 209849] Patch #2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 27 23:34:38 PDT 2013
chris fleizach <cfleizach at apple.com> has denied Lukasz Gajowy
<l.gajowy at samsung.com>'s request for review:
Bug 120300: AX:Null pointer may be dereferenced.
https://bugs.webkit.org/show_bug.cgi?id=120300
Attachment 209849: Patch #2
https://bugs.webkit.org/attachment.cgi?id=209849&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209849&action=review
> Source/WebCore/accessibility/AXObjectCache.cpp:334
> + // Catch the case if an (unsupported) widget type is used. Only
FrameView and ScrollBar are supported now.
But we should still have the ASSERT. We want both assert and (!newObj) check.
That way if it happens in DEBUG we'll know right away, but if it happens in
release, no one will crash
Thanks
More information about the webkit-reviews
mailing list