[webkit-reviews] review granted: [Bug 120385] Simplify and clean SpaceSplitString : [Attachment 209843] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 120385: Simplify and clean SpaceSplitString
https://bugs.webkit.org/show_bug.cgi?id=120385

Attachment 209843: Patch
https://bugs.webkit.org/attachment.cgi?id=209843&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209843&action=review


> Source/WebCore/dom/SpaceSplitString.cpp:240
> +    new (NotNull, spaceSplitStringData) SpaceSplitStringData(keyString,
tokenCount);
> +    AtomicString* tokenArrayStart = spaceSplitStringData->tokenArrayStart();

> +    TokenAtomicStringInitializer tokenInitializer(tokenArrayStart);
> +    tokenizeSpaceSplitString(tokenInitializer, keyString);
> +    ASSERT(tokenInitializer.nextMemoryBucket() - tokenArrayStart ==
tokenCount);
> +    ASSERT(reinterpret_cast<const
char*>(tokenInitializer.nextMemoryBucket()) == reinterpret_cast<const
char*>(spaceSplitStringData) + sizeToAllocate);

I would really like to split this into a tiny inline function.

> Source/WebCore/dom/SpaceSplitString.h:67
> +	   ASSERT(isMainThread());

We should also assert that m_refCount is non-zero here.