[webkit-reviews] review canceled: [Bug 119423] Improve srcset parser : [Attachment 209785] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled Romain Perier
<romain.perier at gmail.com>'s request for review:
Bug 119423: Improve srcset parser
https://bugs.webkit.org/show_bug.cgi?id=119423

Attachment 209785: Patch
https://bugs.webkit.org/attachment.cgi?id=209785&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209785&action=review


I just had a quick look but this seems good.

You need to rebaseline though. The patch does not apply on the bots.

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:328
>  

You can remove this space.

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:360
> +	   imageScaleEnd = (imageScaleEnd == notFound) ? srcSetLen:
imageScaleEnd;

missing space before :

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:365
> +	       separator = srcSetAttribute.find(",", separator + 1);

"," -> ','

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:384
> +	   image.imageURL =
decodeURLEscapeSequences(StringImpl::createWithoutCopying(srcSetAttribute.chara
cters() + imageUrlStart, imageUrlEnd - imageUrlStart));

You could do without the StirngImpl::createWithoutCopying(). It is not gonna be
a big deal here to create a single string, and it will be safer not to share
the memory.