[webkit-reviews] review granted: [Bug 120386] Page::pluginData() should return a reference. : [Attachment 209827] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 120386: Page::pluginData() should return a reference.
https://bugs.webkit.org/show_bug.cgi?id=120386

Attachment 209827: Patch
https://bugs.webkit.org/attachment.cgi?id=209827&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209827&action=review


> Source/WebCore/loader/SubframeLoader.cpp:197
> +    const PluginData& pluginData = page->pluginData();
> +    String pluginFile = pluginData.pluginFileForMimeType(newMIMEType);

Local variable not needed here. The old code had it to help it check against
null.

> Source/WebCore/loader/SubframeLoader.cpp:418
> +	   const PluginData& pluginData = m_frame->page()->pluginData();
> +	   String pluginName = pluginData.pluginNameForMimeType(mimeType);

Local variable not needed here. The old code had it to help it check against
null.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1408
> +		   const PluginData& pluginData =
webPage->corePage()->pluginData();
> +		   if (pluginSupportsExtension(pluginData, extension))

Local variable not needed here. The old code had it to help it check against
null.