[webkit-reviews] review granted: [Bug 120380] [iOS] Don't opt into accelerated composited scrolling for elements with -webkit-overflow-scrolling: touch : [Attachment 209818] Patch with layout tests

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 120380: [iOS] Don't opt into accelerated composited scrolling for elements
with -webkit-overflow-scrolling: touch
https://bugs.webkit.org/show_bug.cgi?id=120380

Attachment 209818: Patch with layout tests
https://bugs.webkit.org/attachment.cgi?id=209818&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209818&action=review


> Source/WebCore/rendering/RenderLayer.cpp:2060
> +	   // On iOS we don't want to opt into accelerated composited
scrolling, which creates scroll bar
> +	   // layers in WebCore, because we use UIKit to composite our scroll
bars.

This comment is in the wrong place. It should go before the #if, not in the
#else side.

I also think that && !PLATFORM(IOS) should go *after* the ENABLE check.

What the comment does not explain is why ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
needs to be true for iOS even though we don’t want to do this. Is there other
code wrapped by ACCELERATED_OVERFLOW_SCROLLING we do want?