[webkit-reviews] review denied: [Bug 120136] [WK2] Add didChangeEnableHighAccuracy callback to WK2 geolocation API : [Attachment 209304] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Hugo Parente Lima
<hugo.lima at openbossa.org>'s request for review:
Bug 120136: [WK2] Add didChangeEnableHighAccuracy callback to WK2 geolocation
API
https://bugs.webkit.org/show_bug.cgi?id=120136

Attachment 209304: Patch
https://bugs.webkit.org/attachment.cgi?id=209304&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
I finally spent the time to read this. The patch is not correct.

WebGeolocationClient is per page. WebGeolocationManager is a WebProcess
concept. WebGeolocationManagerProxy is WebContext concept.
You cannot just mix everything. When the message go to a more general concept,
you need to keep track of the details of the smaller scope.

For example:
- Take a process Alpha with the page A and B. Page A ask for HighAccuracy=true,
page B ask for HighAccuracy=false. With your patch, the last one wins. What
should happen is HighAccuracy should be kept to true because one of the two
live Geolocation object is in that mode.
- Take a UIProcess Beta with two web processes A and B. Same reasoning as
above.
etc.