[webkit-reviews] review granted: [Bug 118553] Hash navigation doesn't affect history when the page is retrieved from appcache : [Attachment 209743] patch2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 118553: Hash navigation doesn't affect history when the page is retrieved
from appcache
https://bugs.webkit.org/show_bug.cgi?id=118553

Attachment 209743: patch2
https://bugs.webkit.org/attachment.cgi?id=209743&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209743&action=review


> Source/WebCore/loader/appcache/ApplicationCacheHost.cpp:89
> +	       substituteData = SubstituteData(resource->data(),
>					       resource->response().mimeType(),

>					      
resource->response().textEncodingName(), KURL());
> +	       substituteData.setShouldRevealToSessionHistory(true);

One further thought. Since the only caller is setting this at construction
time, would be nice to just set this in the constructor, leave out
setShouldRevealToSessionHistory entirely, and maybe even make
m_shouldRevealToSessionHistory const.