[webkit-reviews] review granted: [Bug 120293] setAttributeNode() does not set the new value to an existing attribute if specified attribute is in a different case. : [Attachment 209722] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 120293: setAttributeNode() does not set the new value to an existing
attribute if specified attribute is in a different case.
https://bugs.webkit.org/show_bug.cgi?id=120293

Attachment 209722: Patch
https://bugs.webkit.org/attachment.cgi?id=209722&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209722&action=review


> Source/WebCore/dom/Element.cpp:972
> +    const QualifiedName& existingAttributeName = attributeAt(index).name();

Seems a bit wasteful to fetch this if inSynchronizationOfLazyAttribute is true
and newValue is no different from the old value.