[webkit-reviews] review granted: [Bug 119801] [CSS Grid Layout] Fix grid position resolution : [Attachment 209342] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 119801: [CSS Grid Layout] Fix grid position resolution
https://bugs.webkit.org/show_bug.cgi?id=119801

Attachment 209342: Patch
https://bugs.webkit.org/attachment.cgi?id=209342&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209342&action=review


> Source/WebCore/ChangeLog:16
> +	   resolveGridPositionsFormStyle() so we can use it for the grid size

Typo, resolveGridPositions_From_Style.

> Source/WebCore/rendering/RenderGrid.cpp:768
> +	   ASSERT(position.integerPosition());

This is a well-placed assert. I was worried about negative values here.