[webkit-reviews] review requested: [Bug 120334] Web Inspector: Column Breakpoint not working, may be off by 1 : [Attachment 209709] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 26 20:26:50 PDT 2013


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 120334: Web Inspector: Column Breakpoint not working, may be off by 1
https://bugs.webkit.org/show_bug.cgi?id=120334

Attachment 209709: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=209709&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Fix and test.

The reason that a lot of breakpoints were working currently was that if the
breakpoint was set at the start of a line (column 0) we break anywhere on the
line. That would be the case for non-pretty printed code, or setting a
breakpoint on a line in pretty printed source that happened to be on the start
of a line in the non-pretty-printed code.


More information about the webkit-reviews mailing list