[webkit-reviews] review granted: [Bug 120335] [Windows] some track language tags are not recognized : [Attachment 209697] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 120335: [Windows] some track language tags are not recognized
https://bugs.webkit.org/show_bug.cgi?id=120335

Attachment 209697: Patch
https://bugs.webkit.org/attachment.cgi?id=209697&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209697&action=review


>
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundation
CF.cpp:928
>      if (!primaryAudioTrackLanguage.isNull() && primaryAudioTrackLanguage !=
languageOfPrimaryAudioTrack())
>	   player()->characteristicChanged();

This should be:

    if (primaryAudioTrackLanguage != languageOfPrimaryAudioTrack())
	characteristicsChanged();

>>
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundation
CF.cpp:1113
>> +	// RFC 4646 language tag so extendedLanguageTag returns NULL. In this
case languageCode will return the
> 
> Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]

StyleQueue fail :-O