[webkit-reviews] review granted: [Bug 81419] WebKitTestRunner needs to protect the user's pasteboard contents while running : [Attachment 209674] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 81419: WebKitTestRunner needs to protect the user's pasteboard contents
while running
https://bugs.webkit.org/show_bug.cgi?id=81419

Attachment 209674: proposed fix
https://bugs.webkit.org/attachment.cgi?id=209674&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209674&action=review


> Tools/WebKitTestRunner/mac/PoseAsClass.mm:34
> +    unsigned int imposterMethodCount;

s/unsigned int/unsigned/

> Tools/WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h:4
> + * Copyright (C) 2005, 2006, 2007, 2013 Apple, Inc.	All rights reserved.
> + * Copyright (C) 2007 Graham Dennis (graham.dennis at gmail.com)
> + * Copyright (C) 2007 Eric Seidel <eric at webkit.org>

Just Apple, these other people didn’t write this header.

> Tools/WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:4
> + * Copyright (C) 2005, 2006, 2007, 2013 Apple, Inc.	All rights reserved.
> + * Copyright (C) 2007 Graham Dennis (graham.dennis at gmail.com)
> + * Copyright (C) 2007 Eric Seidel <eric at webkit.org>

What did these people write of this file?

> Tools/WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:84
> ++ (id)alloc
> +{
> +    return NSAllocateObject(self, 0, 0);
> +}

Why is this needed?

> Tools/WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:92
> +    typesArray = [[NSMutableArray alloc] init];
> +    typesSet = [[NSMutableSet alloc] init];
> +    dataByType = [[NSMutableDictionary alloc] init];
> +    pasteboardName = [name copy];
> +    return self;

Why no [super init] here?