[webkit-reviews] review granted: [Bug 120321] [GTK][WK2] Only set up a RedirectedXCompositeWindow if running under an X11 display : [Attachment 209667] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 120321: [GTK][WK2] Only set up a RedirectedXCompositeWindow if running
under an X11 display
https://bugs.webkit.org/show_bug.cgi?id=120321

Attachment 209667: Patch
https://bugs.webkit.org/attachment.cgi?id=209667&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209667&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:60
> +#ifdef GDK_WINDOWING_X11

I've been pondering that we should probably have a macro that tests that both
PLATFORM(X11) and GDK_WINDOWING_X11 are present for these, what do you think?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:387
> +    GdkDisplay* display =
gdk_display_manager_get_default_display(gdk_display_manager_get());
> +    if (GDK_IS_X11_DISPLAY(display)) {
> +	   priv->redirectedWindow =
RedirectedXCompositeWindow::create(IntSize(1, 1),
RedirectedXCompositeWindow::DoNotCreateGLContext);
> +	   if (priv->redirectedWindow)
> +	      
priv->redirectedWindow->setDamageNotifyCallback(redirectedWindowDamagedCallback
, object);
> +    }

Need the preprocessor check here as well.