[webkit-reviews] review granted: [Bug 120319] PageGroup::groupSettings() should return a reference : [Attachment 209664] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 120319: PageGroup::groupSettings() should return a reference
https://bugs.webkit.org/show_bug.cgi?id=120319

Attachment 209664: Patch
https://bugs.webkit.org/attachment.cgi?id=209664&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209664&action=review


LGTM.

> Source/WebCore/page/PageGroup.h:111
> -	   GroupSettings* groupSettings() const { return m_groupSettings.get();
}
> +	   GroupSettings& groupSettings() const { return *m_groupSettings; }

We should also make m_groupSettings a const OwnPtr.