[webkit-reviews] review granted: [Bug 100050] Font's fast code path doesn't handle partial runs correctly when kerning or ligatures are enabled : [Attachment 209638] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 100050: Font's fast code path doesn't handle partial runs correctly when
kerning or ligatures are enabled
https://bugs.webkit.org/show_bug.cgi?id=100050

Attachment 209638: Patch
https://bugs.webkit.org/attachment.cgi?id=209638&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209638&action=review


> Source/WebCore/platform/graphics/WidthIterator.cpp:71
> +    m_characterIndexOfGlyph.reserveCapacity(m_run.length());

Should call reserveInitialCapacity, which is more efficient than
reserveCapacity but can only be called on a newly constructed vector.

> Source/WebCore/platform/graphics/WidthIterator.h:85
> +    Vector<int, 10> m_characterIndexOfGlyph;

Should have a comment somewhere indicating where the 10 came from.