[webkit-reviews] review granted: [Bug 120315] REGRESSION (r154581): Some plugin tests failing in debug bots : [Attachment 209659] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 120315: REGRESSION (r154581): Some plugin tests failing in debug bots
https://bugs.webkit.org/show_bug.cgi?id=120315

Attachment 209659: patch
https://bugs.webkit.org/attachment.cgi?id=209659&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The iterator is doing it wrong. The DOM modification assertion should not be in
the iterator's destructor. Instead it should be in the iterator dereference
operator. We don’t want to require people to carefully scope iterators just to
time the assertion properly, and we don’t want to wait to catch the problem
until long after it happened, either. The hash table iterators had the same
consideration, and that's what we came up with.