[webkit-reviews] review granted: [Bug 120304] Document's renderer is always a RenderView. : [Attachment 209648] "Patch"
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 26 10:03:29 PDT 2013
Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 120304: Document's renderer is always a RenderView.
https://bugs.webkit.org/show_bug.cgi?id=120304
Attachment 209648: "Patch"
https://bugs.webkit.org/attachment.cgi?id=209648&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209648&action=review
> Source/WebCore/dom/Document.h:1195
> + void setRenderer(RenderObject*) WTF_DELETED_FUNCTION;
I suggest leaving out the argument:
void setRenderer() WTF_DELETED_FUNCTION;
Makes it even less likely someone can call it by accident in a compiler that
doesn't support deleting functions.
More information about the webkit-reviews
mailing list