[webkit-reviews] review granted: [Bug 120169] Web Inspector: Breakpoints in the editors gutter should have a contextmenu : [Attachment 209385] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 120169: Web Inspector: Breakpoints in the editors gutter should have a
contextmenu
https://bugs.webkit.org/show_bug.cgi?id=120169

Attachment 209385: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=209385&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209385&action=review


>> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:704
>> +		contextMenu.appendItem(WebInspector.UIString("Add Breakpoint"),
addBreakpoint.bind(this));
> 
> Would anyone prefer the wording "Create Breakpoint"? Xcode does not have an
equivalent of this menu item for adding/creating a breakpoint.

I like Add better.

> Source/WebInspectorUI/UserInterface/SourceCodeTextEditor.js:723
> +	       contextMenu.appendItem(WebInspector.UIString("Reveal in Debugger
Navigator"), revealInSidebar);

I think Debugger Navigator sounds funny. This would read better as Debugger
Navigation Sidebar.