[webkit-reviews] review granted: [Bug 120204] Tighten before/after pseudo element accessors : [Attachment 209534] another

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 120204: Tighten before/after pseudo element accessors
https://bugs.webkit.org/show_bug.cgi?id=120204

Attachment 209534: another
https://bugs.webkit.org/attachment.cgi?id=209534&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209534&action=review


r=me

> Source/WebCore/dom/Element.cpp:2069
> +    if (pseudoElementSpecifier != BEFORE && pseudoElementSpecifier != AFTER)

> +	   return 0;
> +    return pseudoElementSpecifier == BEFORE ? host->beforePseudoElement() :
host->afterPseudoElement();

This might look better as a switch.

> Source/WebCore/dom/Element.cpp:2310
> +bool Element::updateExistingPseudoElement(PseudoElement* existing,
Style::Change change)

existing -> existingPseudoElement?

> Source/WebCore/dom/Element.cpp:2341
> +    if (PseudoElement* existing = beforePseudoElement()) {

existing -> existingPseudoElement?

> Source/WebCore/dom/Element.cpp:2352
> +    if (PseudoElement* existing = afterPseudoElement()) {

existing -> existingPseudoElement?

> Source/WebCore/dom/Element.cpp:2396
> +    if (!hasRareData())
> +	   return;

This could be an assertion instead, if we moved the two clearFooPseudoElement()
calls in clearStyleDerived... after the hasRareData check.

> Source/WebCore/dom/Element.cpp:2404
> +    if (!hasRareData())
> +	   return;

Ditto.