[webkit-reviews] review granted: [Bug 120226] Use ElementTraversal some more : [Attachment 209505] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 120226: Use ElementTraversal some more
https://bugs.webkit.org/show_bug.cgi?id=120226

Attachment 209505: patch
https://bugs.webkit.org/attachment.cgi?id=209505&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209505&action=review


> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1126
> +	   const AtomicString& siblingAriaRole =
sibling->getAttribute(roleAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLObjectElement.cpp:464
> -    for (Element* child = ElementTraversal::firstWithin(this); child; child
= ElementTraversal::nextSibling(child)) {
> +    for (auto child = ElementTraversal::firstChild(this); child; child =
ElementTraversal::nextSibling(child)) {

Looks to me like this is a drive-by bug fix. Was something slightly broken?