[webkit-reviews] review requested: [Bug 115354] [gstreamer] Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data : [Attachment 209485] Patch

[bugzilla-daemon at webkit.org]

Andre Moreira Magalhaes <andrunko at gmail.com> has asked	for review:
Bug 115354: [gstreamer] Disable HTTP request "Accept-Encoding:" header field on
gstreamer source element to avoid receiving the wrong size when retrieving data
https://bugs.webkit.org/show_bug.cgi?id=115354

Attachment 209485: Patch
https://bugs.webkit.org/attachment.cgi?id=209485&action=review

------- Additional Comments from Andre Moreira Magalhaes <andrunko at gmail.com>
(In reply to comment #73)
> (In reply to comment #70)
> > I don't know what other media engines send, but from the test result on the
mac-ews we can see that the mac build is not sending /any/ Accept-Encoding
header, 
> 
> We have two media engines on OSX, AVFoundation and QTKit. We always try to
open media files with AVFoundation first because it is generally more capable
(and modern), and only try to QTKit if AVFoundation fails. This test will
always fall back to QTKit because the cgi does not support HTTP_RANGE, which
AVFoundation requires (we include
LayoutTests/http/tests/media/resources/serve-video.php for the php based cgis
that work with AVFoundation).
> 
> I don't know if adding range support will make this test work in
AVFoundation, but it would be nice to try because it should be easy enough to
add.

New patch contains cgi with range support (code based on
video-throttled-load.cgi - see also bug #120219). I left the test enabled on
mac and will update the patch again if it fails there.