[webkit-reviews] review granted: [Bug 120092] [Windows] Refactor WebFrame to compose with WebFrameLoaderClient (rather than subclass) : [Attachment 209481] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 120092: [Windows] Refactor WebFrame to compose with WebFrameLoaderClient
(rather than subclass)
https://bugs.webkit.org/show_bug.cgi?id=120092

Attachment 209481: Patch
https://bugs.webkit.org/attachment.cgi?id=209481&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209481&action=review


> Source/WebKit/win/WebFramePolicyListener.cpp:125
> +	  
static_cast<WebFrameLoaderClient*>(&frame->loader().client())->receivedPolicyDe
cision(action);

I think you can just cast to WebFrameLoaderClient& here.

> Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h:205
> +    WebFramePolicyListenerPrivate* m_policyListenerPrivate;

I think this can be an OwnPtr.