[webkit-reviews] review granted: [Bug 120215] MediaQuery::expressions() should return a reference : [Attachment 209479] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 23 11:40:16 PDT 2013
Andreas Kling <akling at apple.com> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 120215: MediaQuery::expressions() should return a reference
https://bugs.webkit.org/show_bug.cgi?id=120215
Attachment 209479: Patch
https://bugs.webkit.org/attachment.cgi?id=209479&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209479&action=review
> Source/WebCore/css/MediaQueryEvaluator.cpp:145
> - const Vector<OwnPtr<MediaQueryExp> >* exps =
query->expressions();
> + const Vector<OwnPtr<MediaQueryExp> >& exps =
query->expressions();
Since you are touching every line with this variable on it, you could also
rename it to "expressions" while you're here :)
More information about the webkit-reviews
mailing list