[webkit-reviews] review granted: [Bug 120143] Support in memory compression of rarely used data : [Attachment 209472] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 120143: Support in memory compression of rarely used data
https://bugs.webkit.org/show_bug.cgi?id=120143

Attachment 209472: Patch
https://bugs.webkit.org/attachment.cgi?id=209472&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209472&action=review


> Source/JavaScriptCore/ChangeLog:8
> +	   Include zlib in LD_FLAGS and make UnlinkedCodeBlock make use of
CompressibleVector 

Please quote justification.

> Source/WTF/wtf/Compression.cpp:74
> +    memset(compressedData, 0, currentCapacity);

This kinda sucks.  If it's only here to appease bad compilers, might be worth
commenting on that.