[webkit-reviews] review requested: [Bug 115354] [gstreamer] Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data : [Attachment 209470] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 23 10:17:40 PDT 2013
Andre Moreira Magalhaes <andrunko at gmail.com> has asked for review:
Bug 115354: [gstreamer] Disable HTTP request "Accept-Encoding:" header field on
gstreamer source element to avoid receiving the wrong size when retrieving data
https://bugs.webkit.org/show_bug.cgi?id=115354
Attachment 209470: Patch
https://bugs.webkit.org/attachment.cgi?id=209470&action=review
------- Additional Comments from Andre Moreira Magalhaes <andrunko at gmail.com>
(In reply to comment #71)
> Created an attachment (id=209469) [details]
> Patch
>
> (In reply to comment #68)
> > (From update of attachment 209460 [details] [details])
> > View in context:
https://bugs.webkit.org/attachment.cgi?id=209460&action=review
> >
> > > LayoutTests/http/tests/media/video-accept-encoding.cgi:14
> > > +# Get MIME type if provided. Default to video/mp4.
> > > +my $type = $query->param('type') || "video/mp4";
> >
> > This is only used by one test, which always passes type, so why not just
die if the parameter is missing?
>
> Fixed.
Now for real :P
More information about the webkit-reviews
mailing list