[webkit-reviews] review granted: [Bug 120173] [iOS] Upstream changes to WebCore/style : [Attachment 209395] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 120173: [iOS] Upstream changes to WebCore/style
https://bugs.webkit.org/show_bug.cgi?id=120173

Attachment 209395: Patch
https://bugs.webkit.org/attachment.cgi?id=209395&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209395&action=review


Looks fine. The merged code isn’t great, but we can improve it later; good to
have it upstreamed as a start.

> Source/WebCore/style/StyleResolveTree.cpp:474
> +    CheckForVisibilityChangeOnRecalcStyle checkForVisibilityChange(current,
current->renderStyle());

Seems like a strange way to plug this in. Maybe we can come up with something
better or at least explain why this is platform-specific.

> Source/WebCore/style/StyleResolveTree.cpp:542
> +	       if (settings->fontFallbackPrefersPictographs() &&
document->styleResolverIfExists())
> +		  
documentStyle->font().update(document->styleResolverIfExists()->fontSelector())
;

Would be nice to put style resolver into a local rather than evaluating it
twice.