[webkit-reviews] review granted: [Bug 120168] Fix srcset's image candidate algorithm when DPR exceeds all candidates : [Attachment 209439] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Yoav Weiss <yoav at yoav.ws>'s
request for review:
Bug 120168: Fix srcset's image candidate algorithm when DPR exceeds all
candidates
https://bugs.webkit.org/show_bug.cgi?id=120168

Attachment 209439: Patch
https://bugs.webkit.org/attachment.cgi?id=209439&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209439&action=review


Looks good!
r=me with a minor style change:

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:370
> +    return imageCandidates[i-1].imageURL;

This would look slightly better as:
    return imageCandidates.last().imageURL;

Then we wouldn't have to keep the loop variable alive.