[webkit-reviews] review granted: [Bug 120125] [Windows] Correct Tooltip Text on Windows : [Attachment 209289] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 120125: [Windows] Correct Tooltip Text on Windows
https://bugs.webkit.org/show_bug.cgi?id=120125

Attachment 209289: Patch
https://bugs.webkit.org/attachment.cgi?id=209289&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209289&action=review


> Source/WebKit/win/WebView.cpp:2814
> +	   const Vector<UChar>& toolTipCharacters =
m_toolTip.charactersWithNullTermination(); // Retain buffer long enough to make
the SendMessage call

No need to make this a const reference, can just be a straight up Vector.

> Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp:680
> +    const Vector<UChar>& dialogTitleCharacters =
dialogTitle.charactersWithNullTermination(); // Retain buffer long enough to
make the GetOpenFileName call

Ditto.