[webkit-reviews] review denied: [Bug 76677] AXPress event coordinates are always sent as (0, 0) : [Attachment 209222] Updated patch.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied
samuel_white at apple.com's request for review:
Bug 76677: AXPress event coordinates are always sent as (0, 0)
https://bugs.webkit.org/show_bug.cgi?id=76677

Attachment 209222: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=209222&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209222&action=review


> Source/WebCore/dom/MouseEvent.cpp:289
> +	   // Handle flipped screen coordinates on Mac.
> +	   targetScreenY =
static_cast<int>(targetElement->document()->domWindow()->screen()->height() -
targetScreenY);

For events, this mapping uses NSPoint flipScreenPoint(const NSPoint&
screenPoint, NSScreen *screen)

I don't think your code handles screens whose Y offset is not zero.

I'd prefer this screen flipping code to be shared with the code that
initializes events.