[webkit-reviews] review granted: [Bug 120022] DFG should inline new typedArray() : [Attachment 209247] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 120022: DFG should inline new typedArray()
https://bugs.webkit.org/show_bug.cgi?id=120022

Attachment 209247: the patch
https://bugs.webkit.org/attachment.cgi?id=209247&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209247&action=review


> Source/JavaScriptCore/ChangeLog:18
> +	   is turned into the NewTypedArray intrinsic. Later, of child1 (i.e.
'blah')

s/of/if

>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:171
>> +	bool handleTypedArrayConstructor(int resultOperand, InternalFunction*,
int registerOffset, int argumentCountIncludingThis, TypedArrayType type);
> 
> The parameter name "type" adds no information, so it should be removed. 
[readability/parameter_name] [5]

Fix this :)