[webkit-reviews] review denied: [Bug 119791] [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433) : [Attachment 209210] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Arunprasad Rajkumar
<arurajku at cisco.com>'s request for review:
Bug 119791: [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage
introduced by (r61433)
https://bugs.webkit.org/show_bug.cgi?id=119791

Attachment 209210: Patch
https://bugs.webkit.org/attachment.cgi?id=209210&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209210&action=review


> Source/WebKit/qt/ChangeLog:9
> +	   DRT introduced by http://trac.webkit.org/r61433.

We usually just write r61433 without the full URL in ChangeLogs.

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:164
> +    // Load empty url to send onunload event to currently running page.
> +    // onunload event is mandatory for
LayoutTests/plugins/open-and-close-window-with-plugin.html and
> +    // LayoutTests/plugins/geturlnotify-during-document-teardown.html.

Please mention that this has to do with the virtual table still being intact at
this point.