[webkit-reviews] review granted: [Bug 119797] grammar-markers.html and grammar-markers-hidpi.html pass even if element does not have grammar marker : [Attachment 209197] apply Darin's review

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 119797: grammar-markers.html and grammar-markers-hidpi.html pass even if
element does not have grammar marker
https://bugs.webkit.org/show_bug.cgi?id=119797

Attachment 209197: apply Darin's review
https://bugs.webkit.org/attachment.cgi?id=209197&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209197&action=review


> LayoutTests/editing/spelling/grammar-markers-hidpi.html:44
> +    if (hasMarker)
> +	   testPassed('text : "' + target.innerHTML + '" has grammar marker
under a word "has"');
> +    else
> +	   testFailed('text : "' + target.innerHTML + '" does not have grammar
marker under a word "has"');

Why don't we simply use shouldBeTrue?  You can even use indexOf and length of
"has" instead of magic numbers 4 and 3 to be more descriptive.