[webkit-reviews] review granted: [Bug 120090] [Windows] Report better error messages when WinLauncher/DRT Fail to Run : [Attachment 209232] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 20 15:15:16 PDT 2013


Tim Horton <thorton at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 120090: [Windows] Report better error messages when WinLauncher/DRT Fail to
Run
https://bugs.webkit.org/show_bug.cgi?id=120090

Attachment 209232: Patch
https://bugs.webkit.org/attachment.cgi?id=209232&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209232&action=review


> Tools/win/DLLLauncher/DLLLauncherMain.cpp:177
> +	   return fatalError(L"Unknown Program", L"Failed to determine name of
executabl: " + getLastErrorString(::GetLastError()));

you lost a useful e here


More information about the webkit-reviews mailing list