[webkit-reviews] review granted: [Bug 120078] Replace NodeRenderingContext with RenderStyle& as shouldCreateRenderer() argument : [Attachment 209219] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 20 14:11:05 PDT 2013


Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 120078: Replace NodeRenderingContext with RenderStyle& as
shouldCreateRenderer() argument
https://bugs.webkit.org/show_bug.cgi?id=120078

Attachment 209219: patch
https://bugs.webkit.org/attachment.cgi?id=209219&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209219&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:558
> +    return controls() ? HTMLElement::rendererIsNeeded(style) : false;

I like && better than ? : for cases like this.


More information about the webkit-reviews mailing list