[webkit-reviews] review granted: [Bug 105988] [Mac] Some inspector tests intermittently assert in InspectorOverlay::paint : [Attachment 209218] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 20 13:12:45 PDT 2013


Joseph Pecoraro <joepeck at webkit.org> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 105988: [Mac] Some inspector tests intermittently assert in
InspectorOverlay::paint
https://bugs.webkit.org/show_bug.cgi?id=105988

Attachment 209218: Patch
https://bugs.webkit.org/attachment.cgi?id=209218&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209218&action=review


r=me

> Source/WebCore/inspector/InspectorOverlay.cpp:213
> +    view->updateLayoutAndStyleIfNeededRecursive();
>      ASSERT(!view->needsLayout());

Seems like you can remove the ASSERT now.


More information about the webkit-reviews mailing list