[webkit-reviews] review granted: [Bug 120074] In RenderTableCell::paintCollapsedBorders() check surrounding cells using physical rather than logical direction : [Attachment 209207] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 120074: In RenderTableCell::paintCollapsedBorders() check surrounding cells
using physical rather than logical direction
https://bugs.webkit.org/show_bug.cgi?id=120074

Attachment 209207: Patch
https://bugs.webkit.org/attachment.cgi?id=209207&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch looks good, but it does highlight the fact that we need to rename
cellBefore/After/Above/Below, since they aren't truly physical. I think we
should rename them to:

previousCellInRow, nextCellInRow, cellInPreviousRow, cellInNextRow

I think that would be more clear than above/below/before/after, especially with
how before/after is overloaded to mean "above/below" in writing modes. :)