[webkit-reviews] review denied: [Bug 119979] REGRESSION(r127163): Respect clearance set on ancestors when placing floats : [Attachment 209127] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 119979: REGRESSION(r127163): Respect clearance set on ancestors when
placing floats
https://bugs.webkit.org/show_bug.cgi?id=119979

Attachment 209127: Patch
https://bugs.webkit.org/attachment.cgi?id=209127&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209127&action=review


r-

> Source/WebCore/rendering/RenderObject.h:171
> +    RenderObject* previousInFlowSibling() const
> +    {
> +	   RenderObject* current = previousSibling();
> +	   while (current && current->isOutOfFlowPositioned())
> +	       current = current->previousSibling();
> +	   return current;
> +    }

I would not put this function on RenderObject. I'd put it on RenderBox and call
it previousInFlowSiblingBox. Also, you need to check isFloating() as well,
since you need to skip floats as well as positioned objects.