[webkit-reviews] review granted: [Bug 119849] [CSS Shapes] Complete RasterShape::firstIncludedIntervalLogicalTop() : [Attachment 209202] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 119849: [CSS Shapes] Complete
RasterShape::firstIncludedIntervalLogicalTop()
https://bugs.webkit.org/show_bug.cgi?id=119849

Attachment 209202: Patch
https://bugs.webkit.org/attachment.cgi?id=209202&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209202&action=review


r=me

> Source/WebCore/rendering/shapes/RasterShape.cpp:53
> +    for (int y = minY; y <= bounds().height() - minSize.height(); y++) {

nit: might be useful to explain why we combine absolute position minY with
relative position from bounds().height(). Or just use maxY.

> Source/WebCore/rendering/shapes/RasterShape.cpp:101
> +	   if (lineY > currentLineMaxY) // We've encountered a vertical gap in
lineRects, there are no included intervals.

nit: put the comment inside the if statement. Use { }.