[webkit-reviews] review granted: [Bug 119552] [CSS Grid Layout] Refactor testing code : [Attachment 208410] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 20 09:57:05 PDT 2013


Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 119552: [CSS Grid Layout] Refactor testing code
https://bugs.webkit.org/show_bug.cgi?id=119552

Attachment 208410: Patch
https://bugs.webkit.org/attachment.cgi?id=208410&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208410&action=review


> LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:15

> +PASS getComputedStyle(gridItem, '').getPropertyValue('-webkit-grid-column')
is "10 / auto"

Can’t we preserve the “gridItemWithPositiveInteger” that we had before in here?
Seems like we could just pass a string in and get it just like we did before.


More information about the webkit-reviews mailing list