[webkit-reviews] review granted: [Bug 120048] [GTK] Add stubs for APIs that went missing in the DOM bindings : [Attachment 209147] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 19 21:03:52 PDT 2013


Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 120048: [GTK] Add stubs for APIs that went missing in the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=120048

Attachment 209147: Patch
https://bugs.webkit.org/attachment.cgi?id=209147&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209147&action=review


This is a pretty impressively large collection of API.

> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:164
> +gboolean
> +webkit_dom_bar_info_get_visible(void*)

I think in the implementation itself we want to avoid the double-line function
definition.


More information about the webkit-reviews mailing list