[webkit-reviews] review granted: [Bug 120050] Don't bother using a Vector for the ouput of querySelector, just return the first element found : [Attachment 209152] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 120050: Don't bother using a Vector for the ouput of querySelector, just
return the first element found
https://bugs.webkit.org/show_bug.cgi?id=120050

Attachment 209152: Patch
https://bugs.webkit.org/attachment.cgi?id=209152&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209152&action=review


> Source/WebCore/dom/SelectorQuery.cpp:149
> +		   SelectorQueryTrait::appendOutputForElement(output, element);

> +		   if (SelectorQueryTrait::shouldOnlyMatchFirstElement)

It'll be nice to assert that we never call appendOutputForElement for the first
match case.