[webkit-reviews] review granted: [Bug 120032] Add DRT test to ensure that AccessibilityObject::stringValue() of <input type="file"> is meaningful : [Attachment 209134] Layout test

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 120032: Add DRT test to ensure that AccessibilityObject::stringValue() of
<input type="file"> is meaningful
https://bugs.webkit.org/show_bug.cgi?id=120032

Attachment 209134: Layout test
https://bugs.webkit.org/attachment.cgi?id=209134&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209134&action=review


thanks. a few minor changes suggested

> LayoutTests/accessibility/file-upload-button-stringvalue-expected.txt:7
> +PASS
accessibilityController.accessibleElementById('singleFileUpload').stringValue
is "AXValue: no file selected"

this result should probably move into the mac platform/accessibility

> LayoutTests/accessibility/file-upload-button-stringvalue.html:25
> +   
shouldBeEqualToString("accessibilityController.accessibleElementById('singleFil
eUpload').stringValue", "AXValue: no file selected");

It might be better to do a debug() statement instead of the equalToString so
that other platforms will get what they're expecting which may not include
'AXValue'