[webkit-reviews] review requested: [Bug 120028] ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get() when navigating to an uncached subframe : [Attachment 209123] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 19 14:19:22 PDT 2013
Alexey Proskuryakov <ap at webkit.org> has asked for review:
Bug 120028: ASSERTION FAILED: m_history->provisionalItem() ==
m_requestedHistoryItem.get() when navigating to an uncached subframe
https://bugs.webkit.org/show_bug.cgi?id=120028
Attachment 209123: proposed fix
https://bugs.webkit.org/attachment.cgi?id=209123&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
It's not super clear to me whether it's intentional or a mistake that this
variable is not set for subframes.
The only other place where it is used is
HistoryController::restoreDocumentState(), and I couldn't make a test case that
would show any effect this patch could have on form value restoration.
Hopefully, there is no effect.
More information about the webkit-reviews
mailing list