[webkit-reviews] review requested: [Bug 119915] REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get() : [Attachment 209112] proposed fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 119915: REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem()
== m_requestedHistoryItem.get()
https://bugs.webkit.org/show_bug.cgi?id=119915

Attachment 209112: proposed fix
https://bugs.webkit.org/attachment.cgi?id=209112&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Decided to do a simpler fix.

There are two aspects to dynamically changing cache model:

- Real clients should just set it upfront, changing it after some processes are
created is a poorly defined operation. WKContextSetCacheModel currently fails
to update cache model in Networking process, and it fails to accurately update
cache sizes in WebProcess, especially when running in a non-default session.

- There are three regression tests that attempt to change cache model at
runtime, and this is broken for multiple reasons, most notably because this is
done in injected bundle, and doesn't update Networking process.

Neither appears important enough to address at the moment. Eventually, we
should probably change cache model API to explicitly take a storage session
(ditto for cookie accept policy).