[webkit-reviews] review denied: [Bug 120006] <br> does not get deleted when inlined after some non-textual content. : [Attachment 209078] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 120006: <br> does not get deleted when inlined after some non-textual
content.
https://bugs.webkit.org/show_bug.cgi?id=120006

Attachment 209078: Patch
https://bugs.webkit.org/attachment.cgi?id=209078&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209078&action=review


> LayoutTests/editing/deleting/delete-inline-br.html:15
> +function editingTest() {
> +    for (i = 0; i < 7; i++) {
> +	   moveSelectionForwardByCharacterCommand();
> +    }
> +    deleteCommand();
> +}
> +</script>

This should be a dump-as-markup test.  There is no need for this to be a pixel
test.  r- because of this.

> LayoutTests/platform/efl/TestExpectations:1782
> +# Needs to be rebaselined after landing patch for 120006
> +# https://bugs.webkit.org/show_bug.cgi?id=120006
> +webkit.org/b/120006 editing/deleting/delete-br-004.html [ Failure ]
> +webkit.org/b/120006 editing/deleting/delete-br-005.html [ Failure ]
> +webkit.org/b/120006 editing/deleting/delete-br-006.html [ Failure ]

Please don't add these test expectations. Instead, land this patch and
rebaseline them after the fact.